klsince commented on code in PR #14361:
URL: https://github.com/apache/pinot/pull/14361#discussion_r1841271692
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/LuceneFSTIndexReader.java:
##########
@@ -52,8 +51,7 @@ public LuceneFSTIndexReader(PinotDataBuffer pinotDataBuffer)
_dataBufferIndexInput = new PinotBufferIndexInput(_dataBuffer, 0L,
_dataBuffer.size());
_readFST =
- new FST<>(FST.readMetadata(_dataBufferIndexInput,
PositiveIntOutputs.getSingleton()),
- _dataBufferIndexInput, new OffHeapFSTStore());
+ new FST<>(FST.readMetadata(_dataBufferIndexInput,
PositiveIntOutputs.getSingleton()), _dataBufferIndexInput);
Review Comment:
In recent tests, I found OnHeapFSTStore got used by default
```
public FST(FSTMetadata<T> metadata, DataInput in) throws IOException {
this(metadata, in, new OnHeapFSTStore(DEFAULT_MAX_BLOCK_BITS));
}
```
I'm looking at how to create the reader with OffheapFSTStore? Feel free to
chime in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
