klsince commented on code in PR #12866:
URL: https://github.com/apache/pinot/pull/12866#discussion_r1841269269
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/LuceneFSTIndexReader.java:
##########
@@ -52,7 +52,8 @@ public LuceneFSTIndexReader(PinotDataBuffer pinotDataBuffer)
_dataBufferIndexInput = new PinotBufferIndexInput(_dataBuffer, 0L,
_dataBuffer.size());
_readFST =
- new FST(_dataBufferIndexInput, _dataBufferIndexInput,
PositiveIntOutputs.getSingleton(), new OffHeapFSTStore());
+ new FST<>(FST.readMetadata(_dataBufferIndexInput,
PositiveIntOutputs.getSingleton()),
Review Comment:
what about the OffheapFSTStore?
In recent tests, I found the default became OnheapFSTStore.
```
public FST(FSTMetadata<T> metadata, DataInput in) throws IOException {
this(metadata, new OnHeapFSTStore(DEFAULT_MAX_BLOCK_BITS, in,
metadata.numBytes));
}
```
I'm looking for how to initialize it with OffheapFSTStore. Feel free to
chime in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
