vrajat commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1832629311
########## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/EquivalentStagesFinderTest.java: ########## @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner.logical; + +import java.util.Map; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.query.planner.plannode.MailboxSendNode; +import org.testng.annotations.Test; + +import static org.testng.Assert.*; + + +public class EquivalentStagesFinderTest extends StagesTestBase { + + private final DataSchema _dataSchema1 = new DataSchema( + new String[]{"col1"}, + new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.INT} + ); + private final DataSchema _dataSchema2 = new DataSchema( + new String[]{"col2"}, + new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.STRING} + ); + + @Test + public void justScan() { + MailboxSendNode root = when(tableScan("T1")); + GroupedStages result = EquivalentStagesFinder.findEquivalentStages(root); + assertEquals(result.toString(), "[[0]]"); + } + + @Test + public void independentJoin() { + when( + join( + exchange(1, tableScan("T1")), + exchange(2, tableScan("T2")) + ) + ); + GroupedStages result = EquivalentStagesFinder.findEquivalentStages(stage(0)); + assertEquals(result.toString(), "[[0], [1], [2]]"); + } + + @Test + public void sharedJoin() { + when( + join( + exchange(1, tableScan("T1")), + exchange(2, tableScan("T1")) + ) + ); + GroupedStages result = EquivalentStagesFinder.findEquivalentStages(stage(0)); + assertEquals(result.toString(), "[[0], [1, 2]]"); Review Comment: Does this notation mean that `1, 2` are equivalent and therefore grouped together ? In the previous test, `[[0], [1], [2]]` implies that there no equivalent stages ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
