gortiz commented on code in PR #14338:
URL: https://github.com/apache/pinot/pull/14338#discussion_r1832534022
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -217,8 +217,7 @@ public DataBlock.Type getType() {
*
* @return whether this block is the end of stream.
*/
- // TODO: Update the name to isTerminateBlock.
Review Comment:
I may be biased, but I agree with Jackie. The TODO was subjective and given
we are used to the current term, I would suggest to keep it that way and just
remove the TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
