gortiz commented on issue #14404: URL: https://github.com/apache/pinot/issues/14404#issuecomment-2461580224
I think we should use string concatenation (+) by default and only using the other alternatives when there is an actual reason. For example, in loggers or guava preconditions using their own `{}` or `%s` will be better because it won't allocate the string in cases where the log is not generated or the precondition doesn't fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org