This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 2f731072fd Do not log warning when consumption rate limiter is not 
enabled (#14403)
2f731072fd is described below

commit 2f731072fde059688d726435d5eaf94a3f0938d1
Author: Xiaotian (Jackie) Jiang <17555551+jackie-ji...@users.noreply.github.com>
AuthorDate: Wed Nov 6 17:24:05 2024 -0800

    Do not log warning when consumption rate limiter is not enabled (#14403)
---
 .../data/manager/realtime/RealtimeConsumptionRateManager.java  | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java
index d0a3890e08..0d59899c9e 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java
@@ -87,13 +87,13 @@ public class RealtimeConsumptionRateManager {
     double serverRateLimit =
         
serverConfig.getProperty(CommonConstants.Server.CONFIG_OF_SERVER_CONSUMPTION_RATE_LIMIT,
             CommonConstants.Server.DEFAULT_SERVER_CONSUMPTION_RATE_LIMIT);
-    if (serverRateLimit <= 0) {
-      LOGGER.warn("Invalid server consumption rate limit: {}, throttling is 
disabled", serverRateLimit);
-      _serverRateLimiter = NOOP_RATE_LIMITER;
-    } else {
-      LOGGER.info("A server consumption rate limiter is set up with rate 
limit: {}", serverRateLimit);
+    if (serverRateLimit > 0) {
+      LOGGER.info("Set up ConsumptionRateLimiter with rate limit: {}", 
serverRateLimit);
       MetricEmitter metricEmitter = new MetricEmitter(serverMetrics, 
SERVER_CONSUMPTION_RATE_METRIC_KEY_NAME);
       _serverRateLimiter = new RateLimiterImpl(serverRateLimit, metricEmitter);
+    } else {
+      LOGGER.info("ConsumptionRateLimiter is disabled");
+      _serverRateLimiter = NOOP_RATE_LIMITER;
     }
     return _serverRateLimiter;
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to