gortiz commented on code in PR #14395:
URL: https://github.com/apache/pinot/pull/14395#discussion_r1830529349
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -430,8 +430,8 @@ private SuccessResponse addSchema(Schema schema, boolean
override, boolean force
throw new ControllerApplicationException(LOGGER, e.getMessage(),
Response.Status.BAD_REQUEST, e);
} catch (Exception e) {
_controllerMetrics.addMeteredGlobalValue(ControllerMeter.CONTROLLER_SCHEMA_UPLOAD_ERROR,
1L);
- throw new ControllerApplicationException(LOGGER, String.format("Failed
to add new schema %s.", schemaName),
- Response.Status.INTERNAL_SERVER_ERROR, e);
+ throw new ControllerApplicationException(LOGGER, String.format("Failed
to add new schema %s. Reason: %s",
Review Comment:
I vote against this messages created with String.format. They are difficult
to read and may affect performance (in a negative way). In this case the
performance is not problematic, but it is just a bad idea to try to do that
everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
