itschrispeck commented on code in PR #14351:
URL: https://github.com/apache/pinot/pull/14351#discussion_r1826374131
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SchemaConformingTransformerV2.java:
##########
@@ -402,19 +401,20 @@ private ExtraFieldsContainer processField(SchemaTreeNode
parentNode, Deque<Strin
isIndexable = isIndexable && (null == unindexableFieldSuffix ||
!key.endsWith(unindexableFieldSuffix));
if (!(value instanceof Map)) {
// leaf node
- if (!isIndexable) {
+ if (!isIndexable && value != null) {
extraFieldsContainer.addUnindexableEntry(key, value);
} else {
- if (null != currentNode && currentNode.isColumn()) {
+ if (null != currentNode && currentNode.getValue(value) != null &&
currentNode.isColumn()) {
Review Comment:
nit: `currentNode.getValue(value) != null` can only be true if value is
null, can we early exit when value is null rather than checking in multiple
places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
