rajagopr opened a new pull request, #14340: URL: https://github.com/apache/pinot/pull/14340
## Description Added support to perform task specific validations for the in-built Pinot tasks as well as the plug-in tasks. Modified the `PinotTaskGenerator` interface such that each task can implement it's own custom validation. ## Notes The new utils class `TaskConfigUtils` is kept within the `pinot-controller` module as the existing `TableConfigUtils` resides within the module `pinot-segment-local` and this package doesn't take a dependency on the `pinot-controller` module. The `PinotTaskGenerator` lies within the `pinot-controller` which is required to delegate the task level validation. `pinot-segment-local` depending on `pinot-controller` would create cyclic dependency. ## Testing Added unit tests and tested locally. **Add table configs** ``` 2024/10/30 13:07:10.212 WARN [TaskConfigUtils] [grizzly-http-server-3] Task generator not found for task type: MyCustomTask, while validating table configs for table: students001_OFFLINE ``` **Validate table configs** ``` 2024/10/30 13:13:56.423 WARN [TaskConfigUtils] [grizzly-http-server-2] Task generator not found for task type: MyCustomTask, while validating table configs for table: students001_OFFLINE ``` **Update table configs** ``` 2024/10/30 13:21:18.566 WARN [TaskConfigUtils] [grizzly-http-server-0] Task generator not found for task type: MyCustomTask2, while validating table configs for table: students001_OFFLINE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
