bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1817374230
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/DateTimeTransformerFactory.java:
##########
@@ -29,23 +30,39 @@ private DateTimeTransformerFactory() {
public static BaseDateTimeTransformer getDateTimeTransformer(String
inputFormatStr, String outputFormatStr,
String outputGranularityStr) {
+ return getDateTimeTransformer(inputFormatStr, outputFormatStr,
outputGranularityStr, null);
+ }
+
+ public static BaseDateTimeTransformer getDateTimeTransformer(String
inputFormatStr, String outputFormatStr,
+ String outputGranularityStr, String bucketTimeZoneStr) {
+
DateTimeFormatSpec inputFormat = new DateTimeFormatSpec(inputFormatStr);
DateTimeFormatSpec outputFormat = new DateTimeFormatSpec(outputFormatStr);
DateTimeGranularitySpec outputGranularity = new
DateTimeGranularitySpec(outputGranularityStr);
+ DateTimeZone bucketingTz = null;
+ if (bucketTimeZoneStr != null) {
+ try {
+ // we're not using TimeZone.getTimeZone() because it's globally
synchronized and returns default TZ when str
Review Comment:
I guess we could, if ZoneId is obtained with .of() . I added comment to
explain why I'm not using TimeZone.getTimeZone() like in e.g.
DateTimeFormatPatternSpec and several other places .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
