tibrewalpratik17 commented on PR #14300:
URL: https://github.com/apache/pinot/pull/14300#issuecomment-2437243709

   > We can increase concurrency for segment refresh thereby reducing the total 
time to reload all segments
   
   Are you suggesting an increase in concurrency at the minion level or the 
server level? At the server level, it seems we would still issue a 
SegmentRefreshTask, which means the default concurrency would remain at 1. We 
can investigate performance improvements that might allow us to adjust the 
concurrency configuration.
   
   
   Overall, this appears to be a valuable feature to reduce index build time 
and associated costs for servers! However, we need to consider the trade-off 
between SegmentRefresh and SegmentReload costs. Ultimately, we would still 
issue a SegmentRefresh call to the servers, if I understand correctly. For 
upsert tables with snapshot enabled, we risk losing validDocIDSnapshot during 
downloads from deep store since deep store lacks snapshot copies. This could 
potentially increase refresh times for these tables, as we wouldn't be able to 
utilize the preload feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to