gortiz commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1808508979


##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -100,6 +103,9 @@
 public class PinotClientRequest {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(PinotClientRequest.class);
 
+  @Inject
+  PinotConfiguration _brokerConf;

Review Comment:
   > However is that a better option than injecting the config ?
   
   Probably not. It doesn't make sense to add that into the interface and we 
don't want to depend on the base class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to