Jackie-Jiang commented on code in PR #14199:
URL: https://github.com/apache/pinot/pull/14199#discussion_r1797491985
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -485,6 +490,16 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
if (realtimeTableName == null) {
realtimeTableConfig = null;
}
+
+ if ((realtimeTableConfig != null &&
!_helixAdmin.getResourceIdealState(_clusterName,
Review Comment:
We should avoid looking up ZK in query path. In order to detect disabled
tables, we should add a `Set<String>` in `BrokerRoutingManager` to track
disabled tables. It can be updated in `processSegmentAssignmentChange()` where
we read all ideal states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
