itschrispeck commented on PR #13994: URL: https://github.com/apache/pinot/pull/13994#issuecomment-2408125471
> Certain settings are impossible, e.g. only apply cardinality based optimization and skip optimization for fixed-length type. I'm not too worried about this limitation, but it would be good if we make it possible If I understand the concern correctly, I think users can set `noDictionaryCardinalityRatioThreshold = 0` to effectively skip optimization for fixed-length type? I'd prefer to merge as is, since providing a way to use the cardinality ratio threshold instead of size ratio threshold means making the old size ratio threshold config optional, which is backwards compatible and could be done in the future if the need is found -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
