raghavyadav01 commented on code in PR #14093:
URL: https://github.com/apache/pinot/pull/14093#discussion_r1777891331
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1071,6 +1071,9 @@ public static class Offline {
*/
public static final String SEGMENT_UPLOAD_START_TIME =
"segment.upload.start.time";
+ public static final String CONFIG_SEGMENT_SERVER_UPLOAD_TO_DEEP_STORE =
"segment.server.upload.to.deep.store";
Review Comment:
Fixed.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -214,8 +212,9 @@ public static void validateConsumerType(String streamType,
Map<String, String> s
}
}
- public boolean isServerUploadToDeepStore() {
- return _serverUploadToDeepStore;
+ public boolean isServerUploadToDeepStore(boolean
defaultServerUploadToDeepStore) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
