(pinot) branch master updated: Handling null cases in sum,min,max series builders (#14084)

[ankitsultana]

This is an automated email from the ASF dual-hosted git repository.

ankitsultana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 7668b212bb Handling null cases in sum,min,max series builders (#14084)
7668b212bb is described below

commit 7668b212bb44182779ded3c2d95b158cda886bc3
Author: RAGHVENDRA KUMAR YADAV <raghavmn...@gmail.com>
AuthorDate: Thu Sep 26 10:48:37 2024 -0700

    Handling null cases in sum,min,max series builders (#14084)
---
 .../apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java   | 2 +-
 .../apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java   | 2 +-
 .../pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java      | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java
 
b/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java
index 742b1b32c6..589bbd1baf 100644
--- 
a/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java
+++ 
b/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java
@@ -39,7 +39,7 @@ public class MaxTimeSeriesBuilder extends 
BaseTimeSeriesBuilder {
 
   @Override
   public void addValueAtIndex(int timeBucketIndex, Double value) {
-    if (_values[timeBucketIndex] == null || value > _values[timeBucketIndex]) {
+    if (value != null && (_values[timeBucketIndex] == null || value > 
_values[timeBucketIndex])) {
       _values[timeBucketIndex] = value;
     }
   }
diff --git 
a/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java
 
b/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java
index 93cdab77d4..6247114d61 100644
--- 
a/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java
+++ 
b/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java
@@ -39,7 +39,7 @@ public class MinTimeSeriesBuilder extends 
BaseTimeSeriesBuilder {
 
   @Override
   public void addValueAtIndex(int timeBucketIndex, Double value) {
-    if (_values[timeBucketIndex] == null || value < _values[timeBucketIndex]) {
+    if (value != null && (_values[timeBucketIndex] == null || value < 
_values[timeBucketIndex])) {
       _values[timeBucketIndex] = value;
     }
   }
diff --git 
a/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java
 
b/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java
index 2cf723b8e4..8123dde1bf 100644
--- 
a/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java
+++ 
b/pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java
@@ -39,7 +39,9 @@ public class SummingTimeSeriesBuilder extends 
BaseTimeSeriesBuilder {
 
   @Override
   public void addValueAtIndex(int timeBucketIndex, Double value) {
-    _values[timeBucketIndex] = (_values[timeBucketIndex] == null ? 0 : 
_values[timeBucketIndex]) + value;
+    if (value != null) {
+      _values[timeBucketIndex] = (_values[timeBucketIndex] == null ? 0.0 : 
_values[timeBucketIndex]) + value;
+    }
   }
 
   @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org