kiruphabalu commented on code in PR #14029:
URL: https://github.com/apache/pinot/pull/14029#discussion_r1775524662
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java:
##########
@@ -96,18 +97,44 @@ public Map<ServerRoutingInstance, ServerResponse>
getFinalResponses()
// servers even if the query times out or if servers have not responded.
for (Map.Entry<ServerRoutingInstance, ServerResponse> entry :
_responseMap.entrySet()) {
ServerResponse response = entry.getValue();
-
- // ServerResponse returns -1 if responseDelayMs is not set. This
indicates that a response was not received
- // from the server. Hence we set the latency to the timeout value.
- long latency =
- (response != null && response.getResponseDelayMs() >= 0) ?
response.getResponseDelayMs() : _timeoutMs;
+ long latency;
+
+ if (hasServerNotResponded(response) ||
hasServerReturnedExceptions(response)) {
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
