Jackie-Jiang commented on PR #7219: URL: https://github.com/apache/pinot/pull/7219#issuecomment-2371883490
Right now we have different behavior within segment vs cross segments, which is a kind of confusing: - Within segment, there is no on-the-fly trim, and we simply ignore groups when it is over the threshold - Cross segment, we perform on-the-fly trim, and keep trimming the groups when it is over the threshold - The threshold is different within/cross segment, and is configured with different keys IMO it is easier to use if we make the behavior consistent: Always trim on-the-fly when the threshold is reached, and trim the inner segment result before doing the cross-segment merge. Essentially make the server side segment merge behavior the same as broker side server result merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
