ankitsultana commented on code in PR #14050: URL: https://github.com/apache/pinot/pull/14050#discussion_r1769522530
########## pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java: ########## @@ -107,7 +107,7 @@ public BlockDocIdIterator iterator() { // evaluate the bitmaps in the order of the lowest matching num docIds comes first, so that we minimize the number // of containers (range) for comparison from the beginning, as will minimize the effort of bitmap AND application - bitmapBasedDocIdIterators.sort(Comparator.comparing(x -> x.getDocIds().getCardinality())); + bitmapBasedDocIdIterators.sort(Comparator.comparing(x -> x.getDocIds().getContainerCount())); Review Comment: can you also update the comment just above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org