spanasch opened a new pull request, #13991: URL: https://github.com/apache/pinot/pull/13991
#13685 - Add more UTs for AbstractMetrics class Added unit tests in AbstractMetricsTest to get more coverage of AbstractMetrics. Coverage is not complete and more work will be needed, but this is a good first step. ## Implementation Choices I added a test utility `MetricsInspector` to make the tests easier to write. This will be useful for subsequent tests as well. It uses type-agnostic APIs for robustness (more detail in the code comments). Each new test calls several related APIs. It would be excessive to have a separate test for each API. ## Testing I ran `mvn clean install -Pbin-dist` at the level of pinot-common and verified all tests pass, my added tests were run, and coverage of AbstractMetrics improved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
