jasperjiaguo commented on code in PR #13952:
URL: https://github.com/apache/pinot/pull/13952#discussion_r1755824428
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/ReplicaGroupInstanceSelector.java:
##########
@@ -135,37 +137,31 @@ private Pair<Map<String, String>, Map<String, String>>
selectServersUsingRoundRo
}
private Pair<Map<String, String>, Map<String, String>>
selectServersUsingAdaptiveServerSelector(List<String> segments,
- int requestId, SegmentStates segmentStates, List<String> serverRankList)
{
+ int requestId, SegmentStates segmentStates, Map<String, Integer>
serverRankMap) {
Map<String, String> segmentToSelectedInstanceMap = new
HashMap<>(HashUtil.getHashMapCapacity(segments.size()));
// No need to adjust this map per total segment numbers, as optional
segments should be empty most of the time.
Map<String, String> optionalSegmentToInstanceMap = new HashMap<>();
- for (String segment : segments) {
+ segments.forEach(segment -> {
Review Comment:
nit: while smaller lambdas are good to simplify the code, I think a
multiline block here might complicate the stack trace if some error is thrown
inside. I personally think we can just use for loop here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
