gortiz commented on PR #13969: URL: https://github.com/apache/pinot/pull/13969#issuecomment-2342971443
> What does the fmpp-maven-plugin do? Quick googling and I can't find any decent documentation on it. This is a plugin we use to generate code (specifically, our custom Calcite parser) from [Apache Freemaker](https://freemarker.apache.org/) templates, as indicated by Calcite's docs (see https://calcite.apache.org/docs/adapter.html#extending-the-parser). Why to we use this specific plugin? No idea TBH. In the past we used our own plugin (see https://github.com/apache/pinot/tree/release-1.0.0/contrib/pinot-fmpp-maven-plugin) but we removed it in https://github.com/apache/pinot/pull/12737. I don't remember when but I guess the reason was that given the plugin was in the same reactor, we needed to install that plugin before using it in other projects, otherwise Maven failed saying it wasn't able to find that plugin (this was a mainly a problem whenever we changed Pinot version). I can see there are other maven fmpp plugins but I didn't find anyone that is actually maintained. For example this other [plugin from yahoo](https://github.com/yahoo/freemarker-maven-plugin) is also unmaintained. It looks like the only maintained way to use freemarker at build time is its [ant task](https://freemarker.apache.org/docs/pgui_misc_ant.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
