Jackie-Jiang commented on code in PR #13964:
URL: https://github.com/apache/pinot/pull/13964#discussion_r1752904140
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java:
##########
@@ -132,9 +140,19 @@ protected void downloadSegmentToLocal(String
tableNameWithType, String segmentNa
Collections.shuffle(uris);
return uris;
}, tarredSegmentFile, crypterName);
+ // untar the segment file
+ indexDir = TarCompressionUtils.untar(tarredSegmentFile,
segmentDir).get(0);
} else {
throw e;
}
+ } finally {
+ if (!FileUtils.deleteQuietly(tarredSegmentFile)) {
+ LOGGER.warn("Failed to delete tarred input segment: {}",
tarredSegmentFile.getAbsolutePath());
+ }
+ }
+ if (indexDir == null) {
Review Comment:
Will it ever be `null`? Seems like it can never be `null`, or exception is
thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
