gortiz commented on code in PR #13966:
URL: https://github.com/apache/pinot/pull/13966#discussion_r1751676146
##########
pinot-tools/src/main/resources/examples/batch/colocated/userGroups/userGroups_offline_table_config.json:
##########
@@ -1,6 +1,7 @@
{
"tableName": "userGroups",
"tableType": "OFFLINE",
+ "isDimTable": true,
Review Comment:
Given we also use colocated quickstart to test colocated joins, I think we
should have another table like userGroups that is not a dim table.
This is not an actual problem right now that both colocated and dim joins
have to be enabled explicitly with hints, but will be an issue in the future
when both are going to be applied by default.
\* A problem in the sense that we will need to specify hints to use one or
the other mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
