deepthi912 commented on code in PR #13950: URL: https://github.com/apache/pinot/pull/13950#discussion_r1751059419
########## pinot-controller/src/test/java/org/apache/pinot/controller/util/JsonSerializerTest.java: ########## @@ -0,0 +1,187 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.util; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.restlet.resources.ServerSegmentsReloadCheckResponse; +import org.apache.pinot.common.restlet.resources.TableSegmentsReloadCheckResponse; +import org.apache.pinot.controller.api.resources.PinotLeadControllerRestletResource; +import org.apache.pinot.spi.utils.JsonUtils; +import org.testng.annotations.Test; + +import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertFalse; +import static org.testng.Assert.assertNotNull; +import static org.testng.Assert.assertTrue; + + +/** + * Test class to check for json responses during serialization and deserialization + */ +public class JsonSerializerTest { + @Test + public void testTableReloadResponseSerialization() + throws IOException { + boolean needReload = true; + String instanceId = "instance123"; + ServerSegmentsReloadCheckResponse response = new ServerSegmentsReloadCheckResponse(needReload, instanceId); + Map<String, ServerSegmentsReloadCheckResponse> serversResponse = new HashMap<>(); + serversResponse.put(instanceId, response); + TableSegmentsReloadCheckResponse tableResponse = new TableSegmentsReloadCheckResponse(needReload, serversResponse); + String responseString = JsonUtils.objectToPrettyString(response); + String tableResponseString = JsonUtils.objectToPrettyString(tableResponse); + + assertNotNull(responseString); + assertNotNull(tableResponseString); + JsonNode tableResponseJsonNode = JsonUtils.stringToJsonNode(tableResponseString); + assertTrue(tableResponseJsonNode.get("needReload").asBoolean()); + + JsonNode serversList = tableResponseJsonNode.get("serverToSegmentsCheckReloadList"); + JsonNode serverResp = serversList.get("instance123"); + assertEquals(serverResp.get("instanceId").asText(), "instance123"); + assertTrue(serverResp.get("needReload").asBoolean()); + + assertEquals("{\n" + " \"needReload\" : true,\n" + " \"serverToSegmentsCheckReloadList\" : {\n" Review Comment: Refactored to a more readable one. Thanks for pointing out this property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
