klsince commented on code in PR #13967:
URL: https://github.com/apache/pinot/pull/13967#discussion_r1751039460
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java:
##########
@@ -219,8 +218,7 @@ private void lookup(ValueBlock valueBlock, ValueAcceptor
valueAcceptor) {
}
}
// lookup
- GenericRow row = _dataManager.lookupRowByPrimaryKey(primaryKey);
- Object value = row == null ? null : row.getValue(_dimColumnName);
+ Object value = _dataManager.lookupValue(primaryKey, _dimColumnName);
Review Comment:
nice
but where lookupValues() method is used? or added for future use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
