gortiz commented on code in PR #13907:
URL: https://github.com/apache/pinot/pull/13907#discussion_r1741007304
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginsDirectoryVisitor.java:
##########
@@ -0,0 +1,45 @@
+package org.apache.pinot.spi.plugin;
+
+import java.io.IOException;
+import java.nio.file.FileVisitResult;
+import java.nio.file.Path;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.Collection;
+import java.util.HashSet;
+
+
+class PluginsDirectoryVisitor extends SimpleFileVisitor<Path> {
Review Comment:
nit: I don't like having these individual classes that are designed to
resolve a problem that is specific to some other class. It is not important,
but I would prefer to refactor this class as a inner class of PluginManager.
You would be able then to remove the two attributes (and therefore the
constructor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
