deepthi912 commented on code in PR #13915:
URL: https://github.com/apache/pinot/pull/13915#discussion_r1739563818
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##########
@@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String
tableNameWithType, List<String> colum
return getSegmentsMetadataInternal(tableNameWithType, columns,
segmentsToInclude, timeoutMs);
}
+ /**
+ * This method takes in table name and checks if there exists any mismtach
in the segments/table configs
+ */
+ public JsonNode getSegmentsReloadCheckMetadata(String tableNameWithType, int
timeoutMs)
Review Comment:
I am planning to directly return List<String> segmentsMetadata =
serverSegmentMetadataReader.getCheckReloadSegmentsFromServer(tableNameWithType,
serverInstanceSet, endpoints,
timeoutMs) instead of just needReload flag/consilidating to map.
This could be used in our code to fetch reload flag and later it can extend to
include details of segments to be reloaded corresponding to each server as
well. @Jackie-Jiang Any comment on this suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
