Jackie-Jiang opened a new pull request, #13916: URL: https://github.com/apache/pinot/pull/13916
Even though assignment races are benign, without declaring the fields as `volatile`, instructions might be re-ordered by JVM and causing some threads accessing the uninitialized array. There is no easy way to add a test, but we have seen NPE when reading string literal array, and the only explanation is one thread get an string array without any values filled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org