yashmayya commented on code in PR #13877:
URL: https://github.com/apache/pinot/pull/13877#discussion_r1730705806


##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java:
##########
@@ -352,6 +352,24 @@ public TreeSet<String> getPhysicalColumnNames() {
     return physicalColumnNames;
   }
 
+  /**
+   * Returns a new schema containing only physical columns.
+   *
+   * All properties but the fields are the same.
+   * All field attributes are a shallow copy without the virtual column.
+   */
+  public Schema withoutVirtualColumns() {

Review Comment:
   While there might not be any current use case for it, I think it'd be good 
to also copy over the primary key columns to the new schema?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to