ankitsultana commented on code in PR #13838:
URL: https://github.com/apache/pinot/pull/13838#discussion_r1725777457
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -53,6 +53,9 @@ public enum ServerMeter implements AbstractMetrics.Meter {
PARTIAL_UPSERT_KEYS_NOT_REPLACED("rows", false),
UPSERT_OUT_OF_ORDER("rows", false),
DELETED_KEYS_TTL_PRIMARY_KEYS_REMOVED("rows", false),
+ TOTAL_KEYS_MARKED_FOR_DELETION("rows", false),
Review Comment:
These metrics only show up when the new metadata manager is used?
That seems a bit counter intuitive to me, because the names suggest that
these should be emitted whenever deletion is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
