Jackie-Jiang commented on code in PR #13868:
URL: https://github.com/apache/pinot/pull/13868#discussion_r1725630772
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -218,10 +218,13 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
// Although NullValueVector is implemented as an index, it needs to be
treated in a different way than other indexes
for (FieldSpec fieldSpec : schema.getAllFieldSpecs()) {
+ String columnName = fieldSpec.getName();
if (isNullable(fieldSpec)) {
// Initialize Null value vector map
- String columnName = fieldSpec.getName();
+ LOGGER.info("Column: {} is nullable", columnName);
_nullValueVectorCreatorMap.put(columnName, new
NullValueVectorCreator(_indexDir, columnName));
+ } else if (LOGGER.isInfoEnabled()) {
Review Comment:
We probably don't need this check?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -218,10 +218,13 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
// Although NullValueVector is implemented as an index, it needs to be
treated in a different way than other indexes
for (FieldSpec fieldSpec : schema.getAllFieldSpecs()) {
+ String columnName = fieldSpec.getName();
if (isNullable(fieldSpec)) {
// Initialize Null value vector map
- String columnName = fieldSpec.getName();
+ LOGGER.info("Column: {} is nullable", columnName);
_nullValueVectorCreatorMap.put(columnName, new
NullValueVectorCreator(_indexDir, columnName));
+ } else if (LOGGER.isInfoEnabled()) {
+ LOGGER.info("Column: {} is nullable", columnName);
Review Comment:
```suggestion
LOGGER.info("Column: {} is not nullable", columnName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
