yashmayya opened a new pull request, #13867:
URL: https://github.com/apache/pinot/pull/13867

   - Currently, changes to table configs and schemas aren't logged. This makes 
debugging the history of a table difficult.
   - This minor patch adds info logs to the `addSchema`, `updateSchema`, 
`addTable`, `updateTableConfig` APIs.
   - Sample logs:
   
   ```
   Successfully created new schema: {
     "schemaName" : "testSchema",
     "enableColumnBasedNullHandling" : false,
     "dimensionFieldSpecs" : [ {
       "name" : "OldColumn",
       "dataType" : "INT",
       "notNull" : false
     } ]
   }
   ```
   
   ```
   Successfully updated schema: testSchema with new value: {
     "schemaName" : "testSchema",
     "enableColumnBasedNullHandling" : false,
     "dimensionFieldSpecs" : [ {
       "name" : "NewColumn",
       "dataType" : "STRING",
       "notNull" : false
     }, {
       "name" : "OldColumn",
       "dataType" : "INT",
       "notNull" : false
     } ]
   }
   ```
   
   ```
   Successfully added table with name: airlineStats_OFFLINE and config: 
{"tableName":"airlineStats_OFFLINE","tableType":"OFFLINE","segmentsConfig":{"timeColumnName":"DaysSinceEpoch","timeType":"DAYS","replication":"1","segmentPushType":"APPEND","minimizeDataMovement":false,"segmentAssignmentStrategy":"BalanceNumSegmentAssignmentStrategy"},"tenants":{"broker":"DefaultTenant","server":"DefaultTenant"},"tableIndexConfig":{"aggregateMetrics":false,"starTreeIndexConfigs":[{"dimensionsSplitOrder":["AirlineID","Origin","Dest"],"functionColumnPairs":["COUNT__*","MAX__ArrDelay"],"maxLeafRecords":10}],"enableDefaultStarTree":false,"rangeIndexVersion":2,"loadMode":"MMAP","tierOverwrites":{"hotTier":{"starTreeIndexConfigs":[{"dimensionsSplitOrder":["Carrier","CancellationCode","Origin","Dest"],"skipStarNodeCreationForDimensions":[],"functionColumnPairs":["MAX__CarrierDelay","AVG__CarrierDelay"],"maxLeafRecords":10}]},"coldTier":{"starTreeIndexConfigs":[]}},"nullHandlingEnabled":false,"optimizeDi
 
ctionary":false,"autoGeneratedInvertedIndex":false,"enableDynamicStarTreeCreation":true,"columnMajorSegmentBuilderEnabled":true,"optimizeDictionaryForMetrics":false,"noDictionarySizeRatioThreshold":0.85,"createInvertedIndexDuringSegmentGeneration":false},"metadata":{"customConfigs":{}},"fieldConfigList":[{"name":"ts","encodingType":"DICTIONARY","indexType":"TIMESTAMP","indexTypes":["TIMESTAMP"],"timestampConfig":{"granularities":["DAY","WEEK","MONTH"]},"indexes":null,"tierOverwrites":null},{"name":"ArrTimeBlk","encodingType":"DICTIONARY","indexTypes":[],"indexes":{"inverted":{"enabled":"true"}},"tierOverwrites":{"hotTier":{"encodingType":"DICTIONARY","indexes":{"bloom":{"enabled":"true"}}},"coldTier":{"encodingType":"RAW","indexes":{"text":{"enabled":"true"}}}}}],"ingestionConfig":{"transformConfigs":[{"columnName":"ts","transformFunction":"fromEpochDays(DaysSinceEpoch)"},{"columnName":"tsRaw","transformFunction":"fromEpochDays(DaysSinceEpoch)"}],"segmentTimeValueCheck":true,"rowTim
 
eValueCheck":false,"continueOnError":false},"tierConfigs":[{"name":"hotTier","segmentSelectorType":"time","segmentAge":"3130d","storageType":"pinot_server","serverTag":"DefaultTenant_OFFLINE"},{"name":"coldTier","segmentSelectorType":"time","segmentAge":"3140d","storageType":"pinot_server","serverTag":"DefaultTenant_OFFLINE"}],"isDimTable":false}
   ```
   
   ```
   Successfully updated table config for table: airlineStats_OFFLINE with new 
config: 
{"tableName":"airlineStats_OFFLINE","tableType":"OFFLINE","segmentsConfig":{"timeColumnName":"DaysSinceEpoch","timeType":"DAYS","replication":"1","segmentPushType":"APPEND","minimizeDataMovement":false,"segmentAssignmentStrategy":"BalanceNumSegmentAssignmentStrategy"},"tenants":{"broker":"DefaultTenant","server":"DefaultTenant"},"tableIndexConfig":{"aggregateMetrics":false,"starTreeIndexConfigs":[{"dimensionsSplitOrder":["AirlineID","Origin","Dest"],"functionColumnPairs":["COUNT__*","MAX__ArrDelay"],"maxLeafRecords":10}],"enableDefaultStarTree":false,"rangeIndexVersion":2,"loadMode":"MMAP","tierOverwrites":{"hotTier":{"starTreeIndexConfigs":[{"dimensionsSplitOrder":["Carrier","CancellationCode","Origin","Dest"],"skipStarNodeCreationForDimensions":[],"functionColumnPairs":["MAX__CarrierDelay","AVG__CarrierDelay"],"maxLeafRecords":10}]},"coldTier":{"starTreeIndexConfigs":[]}},"nullHandlingEnabled":fal
 
se,"optimizeDictionary":false,"autoGeneratedInvertedIndex":false,"enableDynamicStarTreeCreation":false,"columnMajorSegmentBuilderEnabled":true,"optimizeDictionaryForMetrics":false,"noDictionarySizeRatioThreshold":0.85,"createInvertedIndexDuringSegmentGeneration":false},"metadata":{"customConfigs":{}},"fieldConfigList":[{"name":"ts","encodingType":"DICTIONARY","indexType":"TIMESTAMP","indexTypes":["TIMESTAMP"],"timestampConfig":{"granularities":["DAY","WEEK","MONTH"]},"indexes":null,"tierOverwrites":null},{"name":"ArrTimeBlk","encodingType":"DICTIONARY","indexTypes":[],"indexes":{"inverted":{"enabled":"true"}},"tierOverwrites":{"hotTier":{"encodingType":"DICTIONARY","indexes":{"bloom":{"enabled":"true"}}},"coldTier":{"encodingType":"RAW","indexes":{"text":{"enabled":"true"}}}}}],"ingestionConfig":{"transformConfigs":[{"columnName":"ts","transformFunction":"fromEpochDays(DaysSinceEpoch)"},{"columnName":"tsRaw","transformFunction":"fromEpochDays(DaysSinceEpoch)"}],"segmentTimeValueChec
 
k":true,"rowTimeValueCheck":false,"continueOnError":false},"tierConfigs":[{"name":"hotTier","segmentSelectorType":"time","segmentAge":"3130d","storageType":"pinot_server","serverTag":"DefaultTenant_OFFLINE"},{"name":"coldTier","segmentSelectorType":"time","segmentAge":"3140d","storageType":"pinot_server","serverTag":"DefaultTenant_OFFLINE"}],"isDimTable":false}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to