Jackie-Jiang commented on PR #13836: URL: https://github.com/apache/pinot/pull/13836#issuecomment-2299964432
> @Jackie-Jiang The idea is that default value of config will be false but provide the users to override the default value for tables which does not have the stream level config for server upload to deepstore. We do not want to change the default but a way to change default for STP. I understand the intention. With the approach in this PR, open source user won't be able to change the default value without modifying the code. Instead, ideally we want user to be able to change this default behavior by putting a cluster config. You may take a look at `CommonConstants.Helix.DEFAULT_HYPERLOGLOG_LOG2M_KEY` which is similar concept -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
