tibrewalpratik17 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1723584505
########## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ########## @@ -60,13 +63,17 @@ public class PinotSinkFunction<T> extends RichSinkFunction<T> implements Checkpo private TableConfig _tableConfig; private Schema _schema; + private String _segmentNamePrefix; + @Nullable private Long _overriddenSegmentCreationTimeMs; Review Comment: Hmm the variable name makes sense in `FlinkSegmentWriter` but in this class it looks like out of context imo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
