Jackie-Jiang commented on code in PR #9416:
URL: https://github.com/apache/pinot/pull/9416#discussion_r1720687117
##########
pom.xml:
##########
@@ -413,6 +413,16 @@
<artifactId>pinot-minion</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
Review Comment:
This is already defined.
##########
pinot-tools/pom.xml:
##########
@@ -125,6 +125,19 @@
<artifactId>pinot-yammer</artifactId>
<scope>runtime</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-yammer</artifactId>
Review Comment:
This is defined twice
##########
pom.xml:
##########
@@ -413,6 +413,16 @@
<artifactId>pinot-minion</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-compound-metrics</artifactId>
Review Comment:
Can you move this after the `pinot-dropwizard` which is already defined in
this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
