yashmayya commented on code in PR #13758:
URL: https://github.com/apache/pinot/pull/13758#discussion_r1716284699
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/NullableSingleInputAggregationFunction.java:
##########
@@ -81,7 +81,9 @@ public void forEachNotNull(int length, BlockValSet
blockValSet, BatchConsumer co
return;
}
- forEachNotNull(length, roaringBitmap.getIntIterator(), consumer);
+ if (roaringBitmap.getCardinality() < length) {
Review Comment:
Actually, on second thought, the other places should be updated to use
`NullableSingleInputAggregationFunction` in
https://github.com/apache/pinot/pull/13791 anyway. So I've pushed the change to
use `roaringBitmap.contains(0, length)` instead of
`roaringBitmap.getCardinality() >= length` to this PR itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
