bziobrowski commented on issue #12647:
URL: https://github.com/apache/pinot/issues/12647#issuecomment-2286805741

   Hello @gortiz  .
   I've spent some time debugging and found that this filter pushdown happens 
during construction of operators (FilteredGroupByOperator to be precise). I 
think fix could either:
   - disable AGGREGATE_CASE_TO_FILTER when aggregation is keyed and add rule 
for rewriting agg(exp) filter (cond) to agg(case when cond then exp end) for 
keyed aggregations 
   - for keyed aggregations, separate aggregation filters from other filters in 
buildFilteredAggregationInfos() and introduce an intermediate 
ProjectionOperator that'd implement agg(case when cond then exp end) .
    
   I'm not sure if it's possible to fetch all key combinations that are missing 
from query output due to filter pushdown. I saw key column dictionary being 
used to estimate key cardinality but I doubt stats are kept on column value 
combinations. 
   
   Please let me know what you think . 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to