siddharthteotia commented on code in PR #13700:
URL: https://github.com/apache/pinot/pull/13700#discussion_r1714918654
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java:
##########
@@ -180,40 +181,42 @@ public boolean needProcess()
DefaultColumnHandler defaultColumnHandler = DefaultColumnHandlerFactory
.getDefaultColumnHandler(null, _segmentMetadata,
_indexLoadingConfig, _schema, null);
if (defaultColumnHandler.needUpdateDefaultColumns()) {
- LOGGER.info("Found default columns need updates");
+ LOGGER.info("Found default columns need updates in segment: {}",
_segmentMetadata.getName());
Review Comment:
(nit) can we just not log the name once at the entry point of the function ?
That way we don't have to insert this into every LOGGER stmt inside if-else etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
