siddharthteotia commented on PR #13791: URL: https://github.com/apache/pinot/pull/13791#issuecomment-2285688929
I see a lot of code has changed on the critical path. Maybe it is just a lot of deletions / refactoring that is looking a lot. Do we have some performance number from a real production workload. Btw, to be clear I am supportive of the change and the rationale behind it. But (if time permits) it may be useful to see results from real use case or at least some kind of CPU profiling numbers from FlameGraphs or JFR metrics even if it is on the synthetic data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org