jasperjiaguo commented on PR #13721: URL: https://github.com/apache/pinot/pull/13721#issuecomment-2276970883
>But we can't change the default without a wide spectrum of consequences and I'd discourage that. Though it's obviously good to have this feature and make it configurable. Yes we should definitely make this at least statically configurable. Considering this is in SPI and injecting config is not easy, can we set up some singleton MMAPConfigRegistry so that the value can be easily configurable in the server scope? Feel free to suggest cleaner ways. @dinoocch @vvivekiyer @ankitsultana -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
