This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push: new 64472356d3 add unit test for TableConfig constructor (#13672) 64472356d3 is described below commit 64472356d3f8ced8e31ddbe7f3ed6382f1052204 Author: sullis <git...@seansullivan.com> AuthorDate: Wed Aug 7 13:08:50 2024 -0700 add unit test for TableConfig constructor (#13672) --- .../pinot/common/utils/config/TableConfigTest.java | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigTest.java b/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigTest.java index 5d10893972..fd9d5e6dbc 100644 --- a/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigTest.java +++ b/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigTest.java @@ -22,10 +22,17 @@ import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; +import java.util.Collections; +import java.util.List; import java.util.stream.Stream; import org.apache.commons.lang3.StringUtils; +import org.apache.pinot.spi.config.table.DedupConfig; +import org.apache.pinot.spi.config.table.HashFunction; +import org.apache.pinot.spi.config.table.QueryConfig; import org.apache.pinot.spi.config.table.TableConfig; import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.config.table.TierConfig; +import org.apache.pinot.spi.config.table.ingestion.IngestionConfig; import org.apache.pinot.spi.utils.JsonUtils; import org.apache.pinot.spi.utils.builder.TableConfigBuilder; import org.testng.annotations.DataProvider; @@ -77,4 +84,29 @@ public class TableConfigTest { realtimeTableConfig.getValidationConfig().setReplicasPerPartition("3"); assertEquals(realtimeTableConfig.getReplication(), 3); } + + @Test + public void testCopyConstructor() { + IngestionConfig ingestionConfig = new IngestionConfig(); + ingestionConfig.setContinueOnError(true); + ingestionConfig.setRowTimeValueCheck(true); + ingestionConfig.setSegmentTimeValueCheck(false); + + TableConfig config = new TableConfigBuilder(TableType.OFFLINE) + .setTableName(RAW_TABLE_NAME) + .setAggregateMetrics(true) + .setRetentionTimeValue("5") + .setRetentionTimeUnit("DAYS") + .setNumReplicas(2) + .setDedupConfig(new DedupConfig(true, HashFunction.MD5)) + .setIngestionConfig(ingestionConfig) + .setQueryConfig(new QueryConfig(2000L, true, false, Collections.emptyMap(), 100_000L, 100_000L)) + .setTierConfigList(List.of(new TierConfig("name", "type", null, null, "storageType", null, null, null))) + .build(); + + TableConfig copy = new TableConfig(config); + + assertEquals(config, copy); + assertEquals(config.toJsonString(), copy.toJsonString()); + } } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org