sullis opened a new pull request, #13678: URL: https://github.com/apache/pinot/pull/13678
**This PR is a work in progress.** # Motivation This PR was motivated by a GitHub issue: https://github.com/apache/pinot/issues/13476 # Modifications - add class: DeleteSegmentStatement - new logic in CalciteSqlParser - new logic DataManipulationStatementParser # About the DeleteSegmentStatement class DeleteSegmentStatement implements Pinot's DataManipulationStatement interface. This class uses ExecutionType.MINION # Feedback requested: - is ExecutionType.MINION the correct choice for DeleteSegmentStatement? The only other choice is ExceptionType.HTTP. I reviewed the source tree and I could not find any Pinot statements that use ExceptionType.HTTP - What is the correct way to delete segments? I have not worked with segments before and I could use some guidance. - Based on my current understanding, it looks like I need to add behavior to the "executeTask" method in SegmentDeletionTaskExecutor.java. I left a "TODO" comment in this file to indicate that the implementation is incomplete # Testing - added DeleteSegmentStatementTest.java - added DataManipulationStatementParserTest.java - added SegmentDeletionMinionClusterIntegrationTest.java # Supporting document This Google Doc has additional information about Pinot SQL endpoints and segment deletion: https://docs.google.com/document/d/1bsg3QKeZiXiFh2__tDkor-v0eDw0QBKuPZiK3DWg_04/edit?usp=sharing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
