Jackie-Jiang commented on code in PR #13650:
URL: https://github.com/apache/pinot/pull/13650#discussion_r1685811439
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -558,7 +558,7 @@ public void testBase64Func()
// non-string identifier used in a filter
sqlQuery = "SELECT fromUtf8(fromBase64(toBase64(toUtf8(AirlineID)))),
AirlineID FROM mytable WHERE "
- + "fromUtf8(fromBase64(toBase64(toUtf8(AirlineID)))) = AirlineID LIMIT
10";
+ + "fromUtf8(fromBase64(toBase64(toUtf8(AirlineID)))) = CAST(AirlineID
as VARCHAR) LIMIT 10";
Review Comment:
We allow implicit casting within UDF (same as v1) here, so it might cause
surprise when the left hand doesn't require type casting and right hand
requires.
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/validate/PinotTypeCoercionImpl.java:
##########
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.validate;
+
+import java.util.List;
+import java.util.stream.Collectors;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlOperator;
+import org.apache.calcite.sql.type.SqlTypeUtil;
+import org.apache.calcite.sql.validate.SqlValidator;
+import org.apache.calcite.sql.validate.implicit.TypeCoercionImpl;
+import org.apache.calcite.util.Util;
+
+
+public class PinotTypeCoercionImpl extends TypeCoercionImpl {
Review Comment:
Please add some javadoc describing the difference between this custom type
coercion vs the default one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
