mcvsubbu opened a new pull request, #13661:
URL: https://github.com/apache/pinot/pull/13661
As of PR #13179, the query response time metrics started to get extremely
high for all tables. The root cause tured out to be a missed initialization in
which the query arrival time was set to 0 by default.
The refactor broke the contract that the broker request handler always
returns the time taken to handle the request.
Added code to initialize the arrival time.
Since the refactor attempted to include client pre-processing time, added
this code under the condition that the value is not already set.
Ideally, callers of the method should add on their own pre and
post-processing time to the time returned by the handleRequest() method.
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
