Jackie-Jiang commented on code in PR #13537:
URL: https://github.com/apache/pinot/pull/13537#discussion_r1681832482
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -317,8 +317,10 @@ public synchronized String submitTask(String
parentTaskName, List<PinotTaskConfi
public synchronized Set<String> getTasks(String taskType) {
Review Comment:
Annotate it with `@Nullable`, also add some javadoc explaining when will it
return null
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -317,8 +317,10 @@ public synchronized String submitTask(String
parentTaskName, List<PinotTaskConfi
public synchronized Set<String> getTasks(String taskType) {
String helixJobQueueName = getHelixJobQueueName(taskType);
WorkflowConfig workflowConfig =
_taskDriver.getWorkflowConfig(helixJobQueueName);
- Preconditions.checkArgument(workflowConfig != null, "Task queue: %s for
task type: %s does not exist",
- helixJobQueueName, taskType);
+ if (workflowConfig == null) {
+ LOGGER.info("Task queue: {} for task type: {} does not exist",
helixJobQueueName, taskType);
Review Comment:
Let's not log here, not worth logging for invalid task type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
