mayankshriv commented on code in PR #13546:
URL: https://github.com/apache/pinot/pull/13546#discussion_r1669065800
##########
pinot-common/src/main/java/org/apache/pinot/common/config/GrpcConfig.java:
##########
@@ -28,6 +28,24 @@ public class GrpcConfig {
public static final String GRPC_TLS_PREFIX = "tls";
public static final String CONFIG_USE_PLAIN_TEXT = "usePlainText";
public static final String CONFIG_MAX_INBOUND_MESSAGE_BYTES_SIZE =
"maxInboundMessageSizeBytes";
+
+ private static final String CONFIG_CHANNEL_SHUTDOWN_TIMEOUT_SECOND =
"channelShutdownTimeoutSecond";
+ private static final int DEFAULT_CHANNEL_SHUTDOWN_TIMEOUT_SECOND = 10;
+
+ // KeepAlive configs
+ private static final String CONFIG_CHANNEL_KEEP_ALIVE_ENABLED =
"channelKeepAliveEnabled";
+ // To control keep alive on no usage
+ private static final boolean DEFAULT_CHANNEL_KEEP_ALIVE_ENABLED = false;
+
+ private static final String CONFIG_CHANNEL_KEEP_ALIVE_TIME_SECONDS =
"channelKeepAliveTimeSeconds";
+ private static final int DEFAULT_CHANNEL_KEEP_ALIVE_TIME_SECONDS = 300; // 5
minutes
Review Comment:
Yeah, I had thought about that, there's a default value though. And then we
will have to differentiate between default vs not-set vs explicitly set (but to
default). Can revisit in follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
