gortiz commented on PR #13553: URL: https://github.com/apache/pinot/pull/13553#issuecomment-2213361819
I don't have experience with sub-modules in GH, but I would say we cannot review, in the same PR, a modification to the code _and_ to the documentation. Even more, GitBook is not designed to be modified from code but from their UI. Recently I've added a couple of PRs improving multi-stage docs directly modifying the md files and they ended up producing errors (like pages that do not appear, broken links, etc). So I don't think this PR would be very useful. IMHO we should move away from GitBook to mkdocs or some similar tool that: 1. Are code first. 2. Support cli tools we can add in the pipeline (ie check for each PR if links are being broken). 3. Reviewers can see the final result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
