mgranderath commented on code in PR #13477:
URL: https://github.com/apache/pinot/pull/13477#discussion_r1668136963


##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##########
@@ -68,7 +68,7 @@ public class ServerSegmentMetadataReader {
 
   public ServerSegmentMetadataReader() {
     _executor = 
Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors());
-    _connectionManager = new PoolingHttpClientConnectionManager();
+    _connectionManager = 
PoolingHttpClientConnectionManagerHelper.createWithSocketFactory();

Review Comment:
   This step does not ensure that. It just configures the SSLSocketFactory to 
use the keystore (and truststore) that is configured in the Pinot 
configuration. Currently this one picks up the system default. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to