gortiz commented on PR #13545: URL: https://github.com/apache/pinot/pull/13545#issuecomment-2210501308
The alternative implementation uses sun.misc.Unsafe. It is very easy to create a new implementation on top of Foreign memory API, but it has two main issues: - Foreign memory API is only supported in Java 21 with preview enabled. It is ready to use in production in Java 22. - Our CI pipelines right now do not support Java 21 only code. I'm trying to add that support in order add the ability to execute multi-stage queries using virtual threads, but it is a bit messy to deal with the CI right now. We have been using the alternative based on sun.misc.Unsafe for a while with no issues. The only thing that is required is to open sun.misc.Unsafe in the newer versions of Java, but IIRC that is already a requirement of Pinot (ie in order to manually release byte buffers). Anyway, we can keep LArray for a while. We may for example first enable our alternative by default in all JVMS for one release and in the next one remove LArray. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
